chore: enable shuffle testing for contrib packages #4065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2025-10-25 18:19:15 Comparing candidate commit af313cc in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
felixge
force-pushed
the
felix.geisendoerfer/chore-enable-shuffle-testing-for-contrib-packages
branch
2 times, most recently
from
ceddef6 to
722d24a
Compare
|
felixge
force-pushed
the
felix.geisendoerfer/chore-enable-shuffle-testing-for-contrib-packages
branch
4 times, most recently
from
6ef48d0 to
25903ed
Compare
Fix slog and logrus to pass their test suite when shuffle testing is enabled. In particular, fix the following two test invocations. go test -test.shuffle 1761195191840193457 ./contrib/log/slog/ go test -test.shuffle 176139568378992735 ./contrib/sirupsen/logrus/ -count 2
The TestServiceName test was failing when run with certain shuffle seeds, e.g.: test -test.shuffle 1761392205507602000 ./contrib/gin-gonic/gin/ This was caused by TestTracerStartedMultipleTimes setting a global service name without restoring the old one. Fix the problem by making TestTracerStartedMultipleTimes clean up after itself.
felixge
force-pushed
the
felix.geisendoerfer/chore-enable-shuffle-testing-for-contrib-packages
branch
from
25903ed to
af313cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #4061
PROF-12822
What does this PR do?
Motivation
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!